feat(explorer): support position = "right"#337
Draft
AJamesyD wants to merge 1 commit intoesmuellert:mainfrom
Draft
feat(explorer): support position = "right"#337AJamesyD wants to merge 1 commit intoesmuellert:mainfrom
AJamesyD wants to merge 1 commit intoesmuellert:mainfrom
Conversation
split.lua already maps "right" correctly and handles width vs height for it. layout.lua was the one gap: arrange() only checked for "left" before calling set_width, so "right" fell through to set_height. Adds "right" to the width checks in arrange() (3 sites) and updates the config comments to document the option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would love to be able to put the explorer panel on the right side. I poked around and it looks like
split.luaalready supports"right"in its position map, so adding it was pretty straightforward.The main change is in
layout.lua:arrange()assumed the panel was either"left"(vertical) or"bottom"(horizontal), so"right"fell through to the wrong sizing path. This adds"right"to the width checks at the three sites inarrange(), and updates the config comments for both explorer and history panels.Without the fix,
"right"technically "works" (the panel appears on the right) but the layout breaks if you're runningcmdheight=0.(AI tooling helped with debugging. Fix verified manually.)